gavin
/
bc
2
2
Fork 4
Code Issues Pull Requests Releases 85 Wiki Activity
Labels Milestones

fix buggy format string in zh_CN.UTF-8.msg #5

Merged
gavin merged 1 commits from xry111/bc:xry111-patch-1 into master 1 year ago
Conversation 2 Commits 1 Files Changed 1
xry111 commented 1 year ago

Several strings in zh_CN.UTF-8.msg are buggy. The most alerming one is the translation of

6 "invalid command-line option: \"%s\""

The translation in zh_CN.UTF-8.msg is:

6 "无效的命令行选项：'%c'(\"%s\")"

We can see the format string is not matched. This causes make test fail (dc crashes).

I think we should add a locale_check.sh, to check if all format strings in translations match to the original English string. But I'm too lazy to do that, at least for now :).

Several strings in `zh_CN.UTF-8.msg` are buggy. The most alerming one is the translation of ~~~~~ 6 "invalid command-line option: \"%s\"" ~~~~~ The translation in `zh_CN.UTF-8.msg` is: ~~~~~ 6 "无效的命令行选项：'%c'(\"%s\")" ~~~~~ We can see the format string is not matched. This causes `make test` fail (`dc` crashes). I think we should add a `locale_check.sh`, to check if all format strings in translations match to the original English string. But I'm too lazy to do that, at least for now :).
gavin commented 1 year ago
Owner

Thank you for the report and the code. I will commit this when I get home. I will also check all of the messages in Chinese.

Thank you for the report and the code. I will commit this when I get home. I will also check all of the messages in Chinese.
gavin closed this pull request 1 year ago
gavin commented 1 year ago
Owner

Thank you for the fix. It has been merged, and I will be pushing fixes for the rest of the Chinese locales soon.

Thank you for the fix. It has been merged, and I will be pushing fixes for the rest of the Chinese locales soon.
The pull request has been merged as 9cb586fc29.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'xry111/bc:xry111-patch-1'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes